solver benchmark: specifying solver-specific options#152
Open
arnavk23 wants to merge 13 commits intoJuliaSmoothOptimizers:mainfrom
Open
solver benchmark: specifying solver-specific options#152arnavk23 wants to merge 13 commits intoJuliaSmoothOptimizers:mainfrom
solver-specific options#152arnavk23 wants to merge 13 commits intoJuliaSmoothOptimizers:mainfrom
Conversation
arnavk23
changed the title
solver-specific options
Contributor
Author
|
@tmigot please review this pr. |
tmigot
requested changes
Oct 30, 2025
Member
tmigot
left a comment
tmigot
left a comment
There was a problem hiding this comment.
Please make sure that the code you suggest work before your PR and ask in the issue if something is not clear. Thanks!!
tmigot
requested changes
Nov 6, 2025
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Contributor
Author
|
@tmigot Please also take a look at this as the issue it mentions and the pr it mentions are closed and merged respectively. |
tmigot
requested changes
Nov 20, 2025
Contributor
Author
|
@tmigot I think we can merge this now. Good to have you back. Will work on the prs and ping you again shortly. Read your paper, loved it. Also can you take a look on the multiple prs on JSO.github.io repo |
tmigot
requested changes
Dec 17, 2025
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds documentation to the SolverBenchmark.jl tutorial explaining how to use solver-specific options in benchmark runs. The PR addresses issue #152 by adding a new section that demonstrates how to set and access solver-specific data through the GenericExecutionStats structure when running benchmarks.
Key Changes
- New documentation section explaining the
solver_specificdictionary mechanism in benchmark results - Code example demonstrating the use of
set_solver_specific!withGenericExecutionStats - Addition of SolverCore dependency to support the example code
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tutorials/introduction-to-solverbenchmark/index.jmd | Adds new "Handling solver_specific in stats" section with explanation and example code demonstrating how to set solver-specific flags |
| tutorials/introduction-to-solverbenchmark/Project.toml | Adds SolverCore dependency with version constraint 0.3 to support the new example code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tmigot
approved these changes
Dec 19, 2025
tmigot
requested changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to tutorial
docs: add "Handling solver_specific in benchmark runs" section to
index.jmdwith explanation, notes, and a short conceptual example showing how to pass solver-specific options to benchmark calls.introduction-to-solverbenchmarksolver_specificin benchmark SolverBenchmark.jl#152